Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mutable defaults in Service.__init__() #16472

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix mutable defaults in Service.__init__() #16472

merged 1 commit into from
Oct 4, 2023

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Oct 2, 2023

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky requested a review from a team as a code owner October 2, 2023 12:20
@altendky altendky mentioned this pull request Oct 2, 2023
Merged
@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Oct 2, 2023
@altendky altendky requested a review from emlowe October 3, 2023 15:28
@cmmarslender cmmarslender merged commit 1654de1 into main Oct 4, 2023
@cmmarslender cmmarslender deleted the altendky-patch-17 branch October 4, 2023 20:47
This was referenced Oct 28, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @emlowe @cmmarslender